/ opencodehub / tests / unit / merge-gates.test.ts
swadhinbiswas test: fix failing tests · 7/10/2026
c4c4ada
203 lines · 6.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
import { beforeEach, describe, expect, it, vi } from "vitest";

let mockDb: any;
const getDatabaseMock = vi.fn(() => mockDb);
const getStackForPrMock = vi.fn(async () => null);
const checkCodeOwnerApprovalsForPRMock = vi.fn(async () => ({ ok: true }));

const fakeSchema: any = {
  pullRequests: { id: {}, repositoryId: {} },
  workflowRuns: { pullRequestId: {}, headSha: {}, createdAt: {} },
  branchProtection: { repositoryId: {}, active: {} },
  reviewRequirements: { repositoryId: {} },
  pullRequestReviews: { pullRequestId: {}, submittedAt: {}, state: {} },
  pullRequestReviewers: { pullRequestId: {}, isRequired: {} },
  requiredStatusChecks: { repositoryId: {}, isRequired: {} },
  externalCIConfigs: { repositoryId: {}, isEnabled: {}, syncStatus: {}, id: {} },
  externalBuilds: { pullRequestId: {}, configId: {}, createdAt: {} },
};

vi.mock("@/db", () => ({
  getDatabase: getDatabaseMock,
  schema: fakeSchema,
}));

vi.mock("@/lib/stacks", () => ({
  getStackForPr: getStackForPrMock,
  getStack: vi.fn(),
}));

vi.mock("@/lib/pr-codeowner", () => ({
  checkCodeOwnerApprovalsForPR: checkCodeOwnerApprovalsForPRMock,
}));

const { canMerge } = await import("@/lib/merge-queue");

function makeDb(overrides: Partial<Record<string, unknown>> = {}) {
  const pr = (overrides.pr as any) || {
    id: "pr1",
    repositoryId: "repo1",
    state: "open",
    isMerged: false,
    headSha: "sha1",
    baseBranch: "main",
    authorId: "author1",
  };

  const reviewRequirements = (overrides.reviewRequirements as any) || {
    minApprovals: 1,
    requireCodeOwner: false,
    requireReReviewOnPush: false,
    dismissStaleReviews: false,
  };

  return {
    query: {
      pullRequests: {
        findFirst: vi.fn(async () => pr),
      },
      workflowRuns: {
        findMany: vi.fn(async () => (overrides.workflowRuns as any[]) || []),
      },
      branchProtection: {
        findMany: vi.fn(async () => (overrides.branchProtection as any[]) || []),
      },
      reviewRequirements: {
        findFirst: vi.fn(async () => reviewRequirements),
      },
      pullRequestReviews: {
        findMany: vi.fn(async () => (overrides.reviews as any[]) || []),
      },
      pullRequestReviewers: {
        findMany: vi.fn(async () => (overrides.requiredReviewers as any[]) || []),
      },
      requiredStatusChecks: {
        findMany: vi.fn(async () => (overrides.requiredStatusChecks as any[]) || []),
      },
      externalCIConfigs: {
        findMany: vi.fn(async () => (overrides.externalCiConfigs as any[]) || []),
      },
      externalBuilds: {
        findMany: vi.fn(async () => (overrides.externalBuilds as any[]) || []),
      },
    },
  };
}

describe("merge gate enforcement", () => {
  beforeEach(() => {
    getStackForPrMock.mockResolvedValue(null);
    checkCodeOwnerApprovalsForPRMock.mockResolvedValue({ ok: true });
  });

  it("blocks when required status check is missing", async () => {
    mockDb = makeDb({
      reviews: [{ reviewerId: "u1", state: "approved", submittedAt: new Date() }],
      requiredStatusChecks: [{ checkName: "build", branch: "main", isRequired: true }],
      workflowRuns: [{ name: "test", status: "success", conclusion: "success", createdAt: new Date() }],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(false);
    expect(result.reason).toContain("Required status check 'build'");
  });

  it("blocks when external CI is still running", async () => {
    mockDb = makeDb({
      reviews: [{ reviewerId: "u1", state: "approved", submittedAt: new Date() }],
      externalCiConfigs: [{ id: "cfg1", name: "Jenkins", isEnabled: true, syncStatus: true }],
      externalBuilds: [{ configId: "cfg1", status: "running", createdAt: new Date() }],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(false);
    expect(result.reason).toContain('External CI "Jenkins" is still running');
  });

  it("blocks when latest review from reviewer is changes_requested", async () => {
    mockDb = makeDb({
      reviewRequirements: {
        minApprovals: 0,
        requireCodeOwner: false,
        requireReReviewOnPush: false,
        dismissStaleReviews: false,
      },
      reviews: [
        { reviewerId: "u1", state: "changes_requested", submittedAt: new Date("2026-02-18T10:00:00Z") },
        { reviewerId: "u1", state: "approved", submittedAt: new Date("2026-02-18T09:00:00Z") },
      ],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(false);
    expect(result.reason).toContain("Changes requested");
  });

  it("blocks when codeowner approvals are required but missing", async () => {
    checkCodeOwnerApprovalsForPRMock.mockResolvedValue({
      ok: false,
      reason: "Code owner approval required",
    });

    mockDb = makeDb({
      reviewRequirements: {
        minApprovals: 1,
        requireCodeOwner: true,
        requireReReviewOnPush: false,
        dismissStaleReviews: false,
      },
      reviews: [{ reviewerId: "u1", state: "approved", submittedAt: new Date() }],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(false);
    expect(result.reason).toContain("Code owner approval required");
  });

  it("blocks when required reviewer has not approved", async () => {
    mockDb = makeDb({
      reviewRequirements: {
        minApprovals: 0,
        requireCodeOwner: false,
        requireReReviewOnPush: false,
        dismissStaleReviews: false,
      },
      requiredReviewers: [{ userId: "u_required", isRequired: true }],
      reviews: [{ reviewerId: "u_other", state: "approved", submittedAt: new Date() }],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(false);
    expect(result.reason).toContain("Required reviewer approvals missing");
  });

  it("passes when required reviewer latest review is approved", async () => {
    mockDb = makeDb({
      reviewRequirements: {
        minApprovals: 0,
        requireCodeOwner: false,
        requireReReviewOnPush: false,
        dismissStaleReviews: false,
      },
      requiredReviewers: [{ userId: "u_required", isRequired: true }],
      reviews: [{ reviewerId: "u_required", state: "approved", submittedAt: new Date() }],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(true);
  });

  it("passes when required checks, external CI, and approvals are satisfied", async () => {
    mockDb = makeDb({
      reviews: [{ reviewerId: "u1", state: "approved", submittedAt: new Date() }],
      requiredStatusChecks: [{ checkName: "build", branch: "main", isRequired: true }],
      workflowRuns: [{ name: "build", status: "success", conclusion: "success", createdAt: new Date() }],
      externalCiConfigs: [{ id: "cfg1", name: "Jenkins", isEnabled: true, syncStatus: true }],
      externalBuilds: [{ configId: "cfg1", status: "success", createdAt: new Date() }],
    });

    const result = await canMerge("pr1");
    expect(result.canMerge).toBe(true);
  });
});