swadhinbiswas Complete code owner enforcement policy introspection UX · 2/19/2026
ca0ff7d
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
import { beforeEach, describe, expect, it, vi } from "vitest";
const {
canReadRepoMock,
compareBranchesMock,
resolveRepoPathMock,
checkCodeOwnerApprovalsMock,
getCodeOwnersSummaryMock,
fakeSchema,
} = vi.hoisted(() => ({
canReadRepoMock: vi.fn(async () => true),
compareBranchesMock: vi.fn(async () => ({
diffs: [{ file: "src/app.ts", additions: 1, deletions: 0 }],
})),
resolveRepoPathMock: vi.fn(async () => "/tmp/repos/demo.git"),
checkCodeOwnerApprovalsMock: vi.fn(async () => ({
canMerge: false,
missingApprovals: [
{
path: "src/app.ts",
requiredOwners: ["@team-core"],
approvedBy: ["alice"],
},
],
})),
getCodeOwnersSummaryMock: vi.fn(async () => [
{ path: "src/app.ts", owners: ["@team-core"] },
]),
fakeSchema: {
users: { username: {} },
repositories: { ownerId: {}, name: {}, id: {} },
pullRequests: { repositoryId: {}, number: {}, id: {} },
reviewRequirements: { repositoryId: {}, requireCodeOwner: {} },
branchProtection: { repositoryId: {}, active: {}, pattern: {}, requireCodeOwnerReviews: {}, id: {} },
} as any,
}));
let mockDb: any;
vi.mock("@/db", () => ({
getDatabase: () => mockDb,
schema: fakeSchema,
}));
vi.mock("@/lib/permissions", () => ({
canReadRepo: canReadRepoMock,
}));
vi.mock("@/lib/git", () => ({
compareBranches: compareBranchesMock,
}));
vi.mock("@/lib/git-storage", () => ({
resolveRepoPath: resolveRepoPathMock,
}));
vi.mock("@/lib/codeowners-enforcement", () => ({
checkCodeOwnerApprovals: checkCodeOwnerApprovalsMock,
getCodeOwnersSummary: getCodeOwnersSummaryMock,
}));
import { GET as codeOwnerEnforcementGet } from "@/pages/api/repos/[owner]/[repo]/pulls/[number]/codeowner-enforcement";
function makeDb({
requireCodeOwner = true,
branchRule = null as any,
} = {}) {
return {
query: {
users: {
findFirst: vi.fn(async () => ({ id: "owner-1" })),
},
repositories: {
findFirst: vi.fn(async () => ({
id: "repo-1",
ownerId: "owner-1",
name: "demo",
diskPath: "repos/owner-1/demo.git",
})),
},
pullRequests: {
findFirst: vi.fn(async () => ({
id: "pr-1",
repositoryId: "repo-1",
number: 12,
baseBranch: "main",
headBranch: "feature",
})),
},
reviewRequirements: {
findFirst: vi.fn(async () => ({
requireCodeOwner,
})),
},
branchProtection: {
findMany: vi.fn(async () => (branchRule ? [branchRule] : [])),
},
},
};
}
async function readJson(response: Response): Promise<any> {
return response.json();
}
describe("pull request codeowner enforcement route", () => {
beforeEach(() => {
vi.clearAllMocks();
mockDb = makeDb();
});
it("returns blocker details when codeowner approval is enforced and missing", async () => {
const response = await codeOwnerEnforcementGet({
params: { owner: "owner-1", repo: "demo", number: "12" },
locals: { user: { id: "user-1", isAdmin: false } },
} as any);
const body = await readJson(response);
expect(response.status).toBe(200);
expect(body?.data?.enforced).toBe(true);
expect(body?.data?.ready).toBe(false);
expect(body?.data?.blockers?.length).toBe(1);
expect(body?.data?.files?.[0]?.approved).toBe(false);
expect(checkCodeOwnerApprovalsMock).toHaveBeenCalledWith("repo-1", "pr-1", ["src/app.ts"]);
});
it("returns non-enforced status when no policy requires codeowner reviews", async () => {
mockDb = makeDb({
requireCodeOwner: false,
branchRule: {
id: "rule-1",
pattern: "main",
requireCodeOwnerReviews: false,
},
});
const response = await codeOwnerEnforcementGet({
params: { owner: "owner-1", repo: "demo", number: "12" },
locals: { user: { id: "user-1", isAdmin: false } },
} as any);
const body = await readJson(response);
expect(response.status).toBe(200);
expect(body?.data?.enforced).toBe(false);
expect(checkCodeOwnerApprovalsMock).not.toHaveBeenCalled();
expect(getCodeOwnersSummaryMock).not.toHaveBeenCalled();
});
});