Swadhin Biswas Feat/federation (#82) · 8/19/2026
c0437ed
215 lines · 6.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
/**
 * Auth API - Register new user
 */
import { getDatabase, schema } from "@/db";
import type { NodePgDatabase } from "drizzle-orm/node-postgres";
import { sessions, users } from "@/db/schema";
import {
  badRequest,
  conflict,
  created,
  parseBody,
  serverError,
} from "@/lib/api";
import { createSession, createToken, hashPassword } from "@/lib/auth";
import { generateId, isValidEmail, isValidUsername, now } from "@/lib/utils";
import { type APIRoute } from "astro";
import { applyRateLimit } from "@/middleware/rate-limit";
import { RegisterUserSchema } from "@/lib/validation";
import { z } from "zod";
import { logger } from "@/lib/logger";
import { initRepository } from "@/lib/git";
import { initRepoInStorage, getDiskPath, finalizeRepoInit, isCloudStorage } from "@/lib/git-storage";
import { withErrorHandler } from "@/lib/errors";

const registerSchema = z.object({
  username: z.string().min(2).max(39),
  email: z.string().email(),
  password: z.string().min(8).max(128),
  displayName: z.string().optional(),
});

export const POST: APIRoute = withErrorHandler(async ({ request, cookies }) => {
  try {
    // ... existing logic ...
    // (Note: Since I can't easily wrap the whole thing blindly, I'll just check specific confusing parts or wrap the whole body)

    // Re-implementing the body to wrap in try-catch for debugging
    // Apply rate limiting
    const rateLimitResponse = await applyRateLimit(request, "auth");
    if (rateLimitResponse) {
      return rateLimitResponse;
    }

    // Check if registration is enabled
    if (process.env.ENABLE_REGISTRATION === "false") {
      return badRequest("Registration is currently disabled");
    }

    // Parse and validate request body
    const parsed = await parseBody(request, registerSchema);
    if ("error" in parsed) return parsed.error;

    const { username, email, password, displayName } = parsed.data;

    // Additional validation with Zod schema (stricter)
    const validation = RegisterUserSchema.safeParse({ username, email, password, displayName });
    if (!validation.success) {
      const errorMessages = validation.error.errors.map(e => e.message).join(', ');
      return badRequest(`Validation failed: ${errorMessages}`);
    }

    // Validate username format
    if (!isValidUsername(username)) {
      return badRequest(
        "Invalid username format. Use only letters, numbers, and hyphens."
      );
    }

    // Validate email format
    if (!isValidEmail(email)) {
      return badRequest("Invalid email format");
    }

    // Enforce password strength requirements
    const { validatePasswordStrength } = await import("@/lib/auth");
    const passwordCheck = validatePasswordStrength(password);
    if (!passwordCheck.valid) {
      return badRequest(`Weak password: ${passwordCheck.errors.join(", ")}`);
    }

    const db = getDatabase() as NodePgDatabase<typeof schema>;

    // Check if username or email already exists
    const existingUser = await db.query.users.findFirst({
      where: (users, { or, eq }) =>
        or(eq(users.username, username), eq(users.email, email)),
    });

    if (existingUser) {
      if (existingUser.username === username) {
        return conflict("Username already taken");
      }
      return conflict("Email already registered");
    }

    // Hash password
    const passwordHash = await hashPassword(password);

    // Create user
    const userId = generateId("usr");
    const timestamp = new Date();

    await db.insert(users).values({
      id: userId,
      username,
      email,
      passwordHash,
      displayName: displayName || username,
      isActive: true,
      emailVerified: false,
      createdAt: timestamp,
      updatedAt: timestamp,
    });

    // Create profile repository (like GitHub's username/username repo)
    try {
      const profileRepoName = username;
      const localGitPath = await initRepoInStorage(username, profileRepoName);
      const readmeContent = `# ${displayName || username}\n\nWelcome to my profile!\n`;
      
      await initRepository(localGitPath, {
        defaultBranch: "main",
        readme: false,
        repoName: profileRepoName,
        ownerName: displayName || username,
      });

      // Insert profile repo into database
      const profileRepoId = generateId("repo");
      const timestamp2 = new Date();
      await db.insert(schema.repositories).values({
        id: profileRepoId,
        ownerId: userId,
        name: profileRepoName,
        slug: profileRepoName,
        description: `${username}'s profile`,
        visibility: "public",
        defaultBranch: "main",
        diskPath: await getDiskPath(username, profileRepoName),
        httpCloneUrl: "",
        sshCloneUrl: "",
        createdAt: timestamp2,
        updatedAt: timestamp2,
      });

      // Commit the README
      const { commitFile } = await import("@/lib/git");
      await commitFile(localGitPath, "main", "README.md", readmeContent, "Initial commit", {
        name: displayName || username,
        email: email,
      });

      // Upload to cloud if needed
      if (await isCloudStorage()) {
        finalizeRepoInit(username, profileRepoName).catch(() => {});
      }

      logger.info({ userId, profileRepoId }, "Profile repository created");
    } catch (err) {
      logger.error({ err, userId }, "Failed to create profile repository (non-fatal)");
    }

    // Create session
    const userAgent = request.headers.get("User-Agent") || undefined;
    const session = await createSession(userId, userAgent);

    // Store session in database
    await db.insert(sessions).values({
      id: session.id,
      userId: session.userId,
      token: session.token,
      userAgent: session.userAgent,
      ipAddress: session.ipAddress,
      expiresAt: new Date(session.expiresAt),
      createdAt: new Date(session.createdAt),
    });

    // Create JWT token
    const token = await createToken({
      userId,
      username,
      email,
      sessionId: session.id,
    });

    // Set session cookie
    cookies.set("och_session", token, {
      path: "/",
      httpOnly: true,
      secure: import.meta.env.PROD,
      sameSite: "lax",
      expires: new Date(session.expiresAt),
    });

    logger.info({ userId, username }, "User registered and logged in");

    return created({
      user: {
        id: userId,
        username,
        email,
        displayName: displayName || username,
      },
      token,
      expiresAt: session.expiresAt,
    });
  } catch (err: any) {
    if (err.code === "23505") {
      return conflict("Username or email already exists");
    }
    logger.error({ err }, "Registration failed");
    return serverError("Registration failed");
  }
});